Override headersForRequest, fixes #1003 #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, needs tests though. |
|
I'm sorry, unfortunately I'm swamped right now and won't be able to contribute to this pull request further at this time. If anyone wants to complete it please go ahead. |
|
If nothing is done by next Friday, I can add the tests! |
|
@f3ndot: would you have some time to add a test? |
|
Ah, I can try to take a look at this later this week |
|
this has been replaced by #1033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1003 which is caused by changes in emberjs/data#3099, whereby the authorization headers are no longer when using Ember Data 2.7 because header constructing code is moved to a separate method.