Typo in docs comment for headersForRequest #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! Just in time for 1.2-beta.1 ;) |
|
@marcoow Oooh, I have an upcoming feature, too. At my job, we built a DeviseTokenAuth authorizer/authenticator. And we want to offer it as a PR. |
|
Cool! How is that different from the existing Devise authenticator/authorizer? |
|
Oh, it's using tokens. The docs in ember-simple-auth have a gist from 2013 to point out that Devise no longer does token-style auth. But that gem, it uses Devise to offer token-based auth for Rails. |
|
Sorry (I was answering the wrong question). I'll make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a docs typo, completing the Mixin's method list.