Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3 readonly tests. #2342

Merged
merged 1 commit into from Nov 29, 2021
Merged

Fixed 3 readonly tests. #2342

merged 1 commit into from Nov 29, 2021

Conversation

candunaj
Copy link
Contributor

I have found bug in 3 unit tests.

expect(() => {
        sessionService.set('isAuthenticated', false);
      }).to.throw;

there should be

}).to.throw();

These tests expect session.isAuthenticated, session.data and session.store to throw an error when set, so I have changed them from oneWay to readOnly.

@marcoow marcoow merged commit 60da254 into master Nov 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixed-readonly-tests branch November 29, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants