Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-release + ember-beta build #2353

Merged
merged 27 commits into from May 26, 2022
Merged

Fix ember-release + ember-beta build #2353

merged 27 commits into from May 26, 2022

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Dec 10, 2021

This adds testing for Ember 4 on CI. This is focused on making things work to unblock us but we should clean up afterwards. There's probably a number of things we can clean up etc. but we should first have coverage for Ember 4 on CI.

closes #2332

@marcoow marcoow force-pushed the fix-ember-4 branch 4 times, most recently from 785ea8a to 94abb48 Compare December 10, 2021 14:01
@marcoow marcoow mentioned this pull request Dec 10, 2021
@marcoow marcoow force-pushed the fix-ember-4 branch 11 times, most recently from c109ccf to fc462f0 Compare December 14, 2021 21:07
@marcoow marcoow force-pushed the fix-ember-4 branch 7 times, most recently from 09285c0 to 241b16d Compare May 26, 2022 12:22
@marcoow
Copy link
Member Author

marcoow commented May 26, 2022

@BobrImperator do you have any idea why the tests fail for the engine in test-app for Ember 4.0 but work for the classic-test-app with Ember 4.0?

I can't seem to spot the difference… I think that's the only thing keeping us from merging this and finally having Ember 4 covered properly on CI

@marcoow marcoow marked this pull request as ready for review May 26, 2022 17:15
@BobrImperator
Copy link
Collaborator

BobrImperator commented May 26, 2022

I believe the problem might be embroider macros acting up, this happens because of a condition inside ember-engines that conditionally registers a custom link-to for versions older than 3.24.1, for some reason in the test-app it's detecting older versions while in the classic it seems to be correct.

On the screenshot is the compiled file of classic-test-app while running against ember-4
image

@marcoow
Copy link
Member Author

marcoow commented May 26, 2022

Awesome 🎉 I also added the Ember 4.0 scenario back in – can't hurt to test that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants