New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ember-release + ember-beta build #2353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
force-pushed
the
fix-ember-4
branch
4 times, most recently
from
December 10, 2021 14:01
785ea8a
to
94abb48
Compare
Merged
marcoow
force-pushed
the
fix-ember-4
branch
11 times, most recently
from
December 14, 2021 21:07
c109ccf
to
fc462f0
Compare
marcoow
force-pushed
the
fix-ember-4
branch
7 times, most recently
from
May 26, 2022 12:22
09285c0
to
241b16d
Compare
The allow-failure configuration we were using actually never worked and GitHub doesn't allow this really – see https://github.com/actions/toolkit/issues/399
@BobrImperator do you have any idea why the tests fail for the engine in I can't seem to spot the difference… I think that's the only thing keeping us from merging this and finally having Ember 4 covered properly on CI |
Awesome 🎉 I also added the Ember 4.0 scenario back in – can't hurt to test that as well |
BobrImperator
approved these changes
May 26, 2022
BobrImperator
force-pushed
the
fix-ember-4
branch
from
May 26, 2022 18:49
4e30154
to
0f3c675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds testing for Ember 4 on CI. This is focused on making things work to unblock us but we should clean up afterwards. There's probably a number of things we can clean up etc. but we should first have coverage for Ember 4 on CI.
closes #2332