Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(embroider): allow test-app embroider-optimizied to fail (should work for regular apps just fine, but not fastboot) #2633

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Aug 18, 2023

We continue to test against embroider, but embroider-optimized for test-app fails due to fastboot.
It should work for non-fastboot apps just fine.

@github-actions
Copy link

Some tests with 'continue-on-error: true' have failed:

  • test-app test:one embroider-optimized

Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit e6078e4 into master Aug 18, 2023
42 checks passed
@BobrImperator BobrImperator deleted the chore-allow-failure-for-embroider-optimized branch August 18, 2023 14:18
@BobrImperator BobrImperator changed the title test(embroider): allow test-app embroider-optimizied to fail test(embroider): allow test-app embroider-optimizied to fail (should work for regular apps just fine, but not fastboot) Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant