bugfix(transform): Disable handlebars transform pre-Ember-1.13 #150
Conversation
|
Can you enable CI testing for 1.12? |
|
Hmm, I assumed that tests would have had to be rewritten for older Ember but it looks like everything just works! 😄 updated |
pzuraq
force-pushed
the
bugfix/turn-off-transform-for-older-versions-of-ember
branch
from
e6b65e6
to
1ddaec0
Compare
|
So I rebased and reran the tests locally. I thought it was weird because I expected some of the tests to fail, upon closer inspection several of them should have. It appears that because this addon may be triggering a bug in ember-cli-version-checker/ember-try where it reports the wrong Ember version. I'm not sure exactly what's going on here, but running I manually removed it and verified that tests failed without the changes from ember-compatibility-helpers. |
|
Also worth noting, with the minimal examples in tests 1.11 actually does work. Dug into this locally and it seems like only certain block statements will trigger the bug, specifically For our purposes, I'd still prefer outright disabling the transforms. We'll be finishing the update to 1.13 soon, so this is just a temp fix to get us over the finish line |
| test('it transforms data-test params to hash pairs on components', function(assert) { | ||
| assert.equal(find('.test11').find('div[data-test-something]').length, 1, 'data-test-something exists'); | ||
| }); | ||
| test('it transforms data-test params to hash pairs on components', function(assert) { |
There was a problem hiding this comment.
I think this should be the only test that fails for Ember < 1.13?
There was a problem hiding this comment.
I think @pzuraq might be right. Using the versionCompat feature of ember-try and ember-source together has some issues at the moment, and we might only be testing against ember-source in all scenarios 😱
There was a problem hiding this comment.
Hm, so "best" solution for now might be to remove this one test for now (as well as investigating the bug and fixing it in ember-try)?
There was a problem hiding this comment.
The whole block of tests I commented out will fail for Ember <1.13 because positional params didn’t exist yet. They passed before because the transform was working (due to incorrect Ember version being detected) and changing the positional params into named params.
Followup to #149, this disables all handlebars transforms in pre-1.13 Ember. The transforms break otherwise, so this is a way to allow users to still get the benefits of test selectors, even if they won't be stripped.