Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add make target, installdocker, for custompios docker build compatibility #155

Closed
wants to merge 2 commits into from

Conversation

mitant
Copy link

@mitant mitant commented Aug 1, 2023

Addresses #141

normal install target and supporting shell scripts untouched
new installdocker target tested locally and builds on windows using custompios instructions for docker-based build of RatOS (mainsail)

Note: extra file changed because your develop branch is behind master by 1 commit ?

KwadFan and others added 2 commits June 2, 2023 21:08
…l-crew#125)

* Fix `makefile` flags on low memory devices

On devices with less than 512MB existing devices will use `-j2` due to wrong condition.

Co-authored-by: Kamil Trzciński <ayufan@ayufan.eu>
@mitant
Copy link
Author

mitant commented Aug 1, 2023

@KwadFan @mryel00 for your consideration. does not touch existing make target so shouldn't break anything :)
try this if you run into issues using docker / custompios instructions per the other PR. I also forgot to mention that I am building on windows specifically, though it shouldn't matter.

@mryel00
Copy link
Member

mryel00 commented Aug 3, 2023

This PR solves the same issue as #158
#158 is a more elegant solution to fix the problem of #141
Therefore I close this PR. Still a big thanks for your consideration to contribute to crowsnest 😄

@mryel00 mryel00 closed this Aug 3, 2023
@mitant
Copy link
Author

mitant commented Aug 3, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants