Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin files to top of gcode files list. #1257

Open
PhilBaz opened this issue Feb 7, 2023 · 4 comments · May be fixed by #1684
Open

Pin files to top of gcode files list. #1257

PhilBaz opened this issue Feb 7, 2023 · 4 comments · May be fixed by #1684
Labels
good first issue Simple task for new contributors 💡 Type: FR Requests a new feature

Comments

@PhilBaz
Copy link

PhilBaz commented Feb 7, 2023

Requested feature:

Would be nice to have the ability to pin frequently used files to the top of the gcode files list. Then maybe an option to have this be applied on the the list page, the preview on the main page, or both.

Solves the following problem:

Hunting...

Additional information:

Sorry for all the requests! Looking forward to the next update :)

@PhilBaz PhilBaz added the 💡 Type: FR Requests a new feature label Feb 7, 2023
@meteyou meteyou added the good first issue Simple task for new contributors label Apr 16, 2023
@GAZ082
Copy link

GAZ082 commented May 29, 2023

As discussed in another ticket, if the width real state is a concern, this can be added to the right click menu and color code the file name or make a pin visible.

@meteyou
Copy link
Member

meteyou commented May 29, 2023

i think this is a good option, instead to have a own column for the pins, to safe space on the screen.

@4rnoP
Copy link

4rnoP commented Dec 11, 2023

Hi,
I'm new to the mainsail project and would like to implement this feature.
However, I'm not sure what would be the optimal way of saving the pinned files. To my understanding, the only way to save persistent information is to save it with the database API of moonraker, maybe under something like gcodefiles.pinned under the mainsail namespace, and it would contain the list of pinned items ?

Any guidance would be appreciated :)

@meteyou
Copy link
Member

meteyou commented Dec 11, 2023

@4rnoP Thank you for your interest! Yes, you are right. You have to write the files (at least the names or IDs) to the Moonraker DB. I would name the namespace gcodefiles.pinnedFiles to be more precise.

Just as a further idea:
I suggest adding a 4th tab to the status panel. But since it is already tight in some languages, you should replace the words with icons at the same time. You should also pay attention to this PR (#1678). I will merge it in the next few days. Currently, I still have to finalize the light-theme PR.

We only have these current docs for contributors: https://docs.mainsail.xyz/overview/development

@4rnoP 4rnoP linked a pull request Dec 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple task for new contributors 💡 Type: FR Requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants