Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve contrast of job queue items count #1678

Merged

Conversation

mdziekon
Copy link
Contributor

@mdziekon mdziekon commented Dec 8, 2023

Description

Job queue tab has a counter displaying current items count. The counter itself works fine, however it's presented as a gray text, which blends with the background and neighboring text. This quite poor contrast might lead to poor reception of the counter functionality (eg. for me, I usually forget that I've put something in the queue, because the counter is nearly indistinguishable from the tab's label).

To improve the "contrast" (so to speak) of the feature, a simple Badge component can be used instead of text interpolation with the tab's title, allowing it to be displayed slightly different than the neighboring text (the "contrast" improvement comes mainly from the different element being used rather than just color change). This approach also allows it to change its background depending on how many items we've placed in the queue (gray for 0, blue for 1+; blue chosen as information color).

This proposal (in a form of a ready made Pull Request) implements this change and cleans up any localisation files from previous interpolation formatting.

Related Tickets & Documents

N/A

Mobile & Desktop Screenshots/Recordings

Before:

before_empty_queue
before_populated_queue
before_populated_queue_open

After:

after_empty_queue
after_empty_queue_open
after_populated_queue
after_populated_queue_open

[optional] Are there any post-deployment tasks we need to perform?

No

Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Language file analysis report:

File Missing Keys Unused Keys
cz.json 135 8
da.json 18 1
de.json 15 0
en.json 0 0
es.json 56 7
fr.json 1 1
hu.json 273 10
it.json 18 1
ja.json 137 8
ko.json 133 8
nl.json 130 8
pl.json 18 1
pt.json 110 7
ru.json 110 7
tr.json 67 5
uk.json 252 10
zh.json 18 1
zh_TW.json 169 7

@mdziekon mdziekon force-pushed the feature/job-queue-better-indicator branch from 18a5c16 to 8dc6f3a Compare December 8, 2023 22:23
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Language file analysis report:

File Missing Keys Unused Keys
cz.json 135 8
da.json 18 1
de.json 15 0
en.json 0 0
es.json 56 7
fr.json 1 1
hu.json 273 10
it.json 18 1
ja.json 137 8
ko.json 133 8
nl.json 130 8
pl.json 18 1
pt.json 110 7
ru.json 110 7
tr.json 67 5
uk.json 252 10
zh.json 18 1
zh_TW.json 169 7

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
cz.json 135 8
da.json 18 1
de.json 15 0
en.json 0 0
es.json 56 7
fr.json 1 1
hu.json 273 10
it.json 18 1
ja.json 137 8
ko.json 133 8
nl.json 130 8
pl.json 18 1
pt.json 110 7
ru.json 110 7
tr.json 67 5
uk.json 252 10
zh.json 18 1
zh_TW.json 169 7

@meteyou
Copy link
Member

meteyou commented Dec 16, 2023

@mdziekon thx for the PR. I only changed the badge to inline, because it was very close to the top border of the tab.

@meteyou meteyou merged commit eeaa6a4 into mainsail-crew:develop Dec 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants