Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.2.0-beta3] gcodes in subfolder from gcode page not added to jobqueue #825

Closed
dw-0 opened this issue May 18, 2022 · 0 comments · Fixed by #826
Closed

[v2.2.0-beta3] gcodes in subfolder from gcode page not added to jobqueue #825

dw-0 opened this issue May 18, 2022 · 0 comments · Fixed by #826
Assignees
Labels
Prio: 1 High ⚡ Type: Bug Something isn't working

Comments

@dw-0
Copy link
Member

dw-0 commented May 18, 2022

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

It is not possible to add gcode files from the gcode page to the jobqueue anymore, if the gcode is located in a subfolder.
Adding the same file in the same subfolder from the files tab in the status panel on the dashboard works fine.

After trying to add a gcode to the jobqueue this way and switching between dashboard and gcode file page also results in an issue in the files tab of the status panel:
22-05-18_11-00-59_chrome
It seems like all files from within the subfolder get added to the files tab, but with their location being the root directory. The files do not exist at that location. Trying to add those "phantom files" to the jobqueue or start printing them won't work obviously, they shouldn't be added to the files tab at all.

What did you expect to happen instead?

Correctly adding the selected file to the jobqueue.
Not causing an issue of displaying files that don't exist.

How to reproduce this bug?

reproducing the initial issue:

  1. switch to the gcode files page
  2. switch into a subfolder
  3. try to add a file to the jobqueue
  4. observe that nothing seems to happen and the jobqueue panel is not appearing on the right side on the gcode files page
  5. switch to the dashboard status panel
  6. observe that no file was added to the jobqueue there as well

reproducing the displaying issue:

  1. switch back to the gcode files page
  2. switch back to the dashboard status panel files tab
  3. observe that files were added to the list, that usually were located in the subfolder, now appear to be located in the root directory

Additional information:

No response

@dw-0 dw-0 added ⚡ Type: Bug Something isn't working Prio: 1 High labels May 18, 2022
meteyou added a commit that referenced this issue May 18, 2022
fixes #825

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: 1 High ⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants