Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Visual Assistet Nozzle Offset Calibration for IDEX printers or Toolchangers #1557

Closed

Conversation

HelgeKeck
Copy link

@HelgeKeck HelgeKeck commented Sep 16, 2023

Description

All needed informations can be found here:
https://github.com/HelgeKeck/vcore-idex/blob/main/doc/vaoc.md

Atm this PR adds a overlay over a Adaptive MJPEG Streamer camera.

This is not a good solution, i request help for a proper implementation.

Ideally this would be a completely own panel where i can choose any type camera.

@HelgeKeck HelgeKeck closed this Sep 16, 2023
@HelgeKeck HelgeKeck reopened this Sep 16, 2023
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

@HelgeKeck
Copy link
Author

HelgeKeck commented Sep 18, 2023

With multiple tools the coordinates are overlayed
image

@meteyou
Copy link
Member

meteyou commented Sep 18, 2023

Thanks for all your work! I will check this PR as soon as possible and fix the package.lock issue.

@HelgeKeck
Copy link
Author

HelgeKeck commented Sep 18, 2023

Thanks for all your work! I will check this PR as soon as possible and fix the package.lock issue.

no hurry, packagelock issue is fixed already. whenever you have time

making the webcam setting to enable to overlay exclusive to adaptive mjpeg streamer cameras.
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

@HelgeKeck
Copy link
Author

even if i was able to add a universal overlay to each camera type, i realized it doesnt make a lot of sense now. the rendering strategies are to different for the camera types, this would require to much changes.

i limited the webcam setting, to enable the overlay, to adaptivemjpeg cameras. i think thtats totally fine, you wont connect a IP or webrtc camera anyway as a nozzle cam

so from my point i am happy wiht it as it is now

@meteyou
Copy link
Member

meteyou commented Sep 18, 2023

webrtc is just fine for nozzle cams, because you can also use higher resolutions and more FPS, but please let me check a "generic" option to implement it...

@HelgeKeck
Copy link
Author

sure, the problem i encountered is that i need to draw the crosshairs directly onto the image, thats difficult for the video renderers for example

if i could get a universal drawing context that would be nice

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 14 2
en.json 0 0

merge the newest mainsail version into the nozzle overlay branch
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 3

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@HelgeKeck HelgeKeck closed this Oct 1, 2023
@HelgeKeck HelgeKeck deleted the nozzle-offset-calibration branch October 1, 2023 14:28
@mryel00 mryel00 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants