Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add confirmation dialog to cooldown button #1808

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

ReDragon710
Copy link
Contributor

@ReDragon710 ReDragon710 commented Mar 5, 2024

Description

This PR adds the feature confirmation dialog to "COOLDOWN" button. (same looking dialog as the "Emergency Stop")

Related Tickets & Documents

no issue number, too many times I clicked this button by mistake.

Mobile & Desktop Screenshots/Recordings

image
image

[optional] Are there any post-deployment tasks we need to perform?

no

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

and remove "info color" toolbar, fix icon and add also the dialog to the presets dropdown cooldown button.

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

…tion

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou
Copy link
Member

meteyou commented Mar 13, 2024

sry for the long delay. i saw in your PR that the e-stop dialog is fullscreen. i think this should not be fullscreen and i created a PR to fix this (#1816).

i also adapted your PR to this, removed the blue toolbar, changed the icon to the cooldown icon and merged it in your PR.

but nonetheless. thanks for your PR!

@meteyou meteyou merged commit 972266d into mainsail-crew:develop Mar 13, 2024
10 checks passed
@ReDragon710
Copy link
Contributor Author

Yeah, I saw the full screen but I check the other confirmations and it was the same for them so I decided not to touch this
thank you, hope to help more in the future :)

@meteyou
Copy link
Member

meteyou commented Mar 14, 2024

You are welcome to create PRs if you have a good idea to add to Mainsail.

Only panels like probe_calibrate, which contain a lot of content, should be fullscreen. Simple questions like "Are you sure?" are sufficient for a small dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants