Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lengthMenu drop-down on monitoring sites list table #653

Merged
merged 1 commit into from Apr 2, 2024

Conversation

dtugend
Copy link
Contributor

@dtugend dtugend commented Feb 25, 2024

All Submissions:

Explanation

This is only fixing a copy pasta mistake that is in the master branch, causing the length drop-down on Monitoring page to only display then length drop-down 10 (that currently does 10) and 25 (that currently does all).

"Good" example in master branch:

"lengthMenu" : [ [<?php echo esc_js( $pagelength_val ); ?>, -1 ], [<?php echo esc_js( $pagelength_title ); ?>, "All" ] ],

"Copy pasta mistake" example in master branch that this pull-request fixes:

"lengthMenu" : [ [<?php echo intval( $pagelength_val ); ?>, -1 ], [<?php echo esc_js( $pagelength_title ); ?>, "All" ] ],

Only changed is intval to esc_js to bring it in line with other tables code.

Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thanghv thanghv merged commit a47a58e into mainwp:master Apr 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants