[OSSM-107] Add LuaJIT patch for s390x #103
Conversation
|
Hi @yselkowitz. Thanks for your PR. I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The build flags and s390x patches are handled in maistra/envoy#103. The ppc64 patch does not currently apply and needs to be rebased against the currently used luajit snapshot. When that is done, then PPC_SKIP_TARGETS can be removed.
|
/ok-to-test |
|
@yselkowitz: Thanks for the PR. This lgtm, provided CI is happy. @jwendell: could you too take a look please? |
There was a problem hiding this comment.
We don't have a way to test this as we only build for x86 on this CI. We will only know if it works as desired once this reaches proxy and we do a build in brew.
@yselkowitz Could you please add the jira ticket number in the PR title?
yselkowitz
changed the title
|
Retitled the PR. |
The build flags and s390x patches are handled in maistra/envoy#103. The ppc64 patch does not currently apply and needs to be rebased against the currently used luajit snapshot. When that is done, then PPC_SKIP_TARGETS can be removed.
* Add LuaJIT patch for s390x * Move proxy luajit build flags patch to envoy
* Add LuaJIT patch for s390x * Move proxy luajit build flags patch to envoy
Commit Message: Add LuaJIT patch for s390x
Additional Description: This is a followup from comments in maistra/proxy#114
Risk Level: Low
Testing: Scratch build downstream
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: Maintains status-quo on s390x wrt luajit plugin.
/cc @dmitri-d