Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outh2: passthrough of authorization header when filter is matched (#2… #288

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

twghu
Copy link
Contributor

@twghu twghu commented Sep 28, 2023

…3489)

Authorization header sanitation altered headers before the passthrough evaluation. Therefore, move of passthrough header matching to the beginning if the header evaluation, so the unaltered request is passed through.
Introduces a new metric: oauth_passthrough counter.

Signed-off-by: Timo Haas haastimo@gmx.de
(cherry picked from commit f52f99e)

https://issues.redhat.com/browse/OSSM-4873

…3489)

Authorization header sanitation altered headers before the passthrough evaluation.
Therefore, move of passthrough header matching to the beginning if the header evaluation,
so the unaltered request is passed through.
Introduces a new metric: oauth_passthrough counter.

Signed-off-by: Timo Haas <haastimo@gmx.de>
(cherry picked from commit f52f99e)
@openshift-ci openshift-ci bot added the size/M label Sep 28, 2023
@twghu twghu added okay to merge tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. labels Sep 28, 2023
Copy link
Contributor

@tedjpoole tedjpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-robot openshift-merge-robot merged commit 78bfca7 into maistra:maistra-2.4 Sep 28, 2023
2 checks passed
@twghu twghu deleted the oauth2 branch September 28, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge size/M tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants