Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes MAISTRA-2202 updated expired certs #80

Merged
merged 1 commit into from Mar 12, 2021
Merged

Fixes MAISTRA-2202 updated expired certs #80

merged 1 commit into from Mar 12, 2021

Conversation

dmitri-d
Copy link
Contributor

  • test/config/integration/certs
  • test/extensions/transport_sockets/tls/test_data

also a small change in test/integration/integration_test.cc to get
ResponseFramedByConnectionCloseWithReadLimits passing.
TestDelayedConnectionTeardownTimeoutTrigger can be flaky due to delayed
close repeatedly firing too early.

Fixes MAISTRA-2202 updated expired certs
39d5b37 
 - test/config/integration/certs
 - test/extensions/transport_sockets/tls/test_data

 also a small change in test/integration/integration_test.cc to get
ResponseFramedByConnectionCloseWithReadLimits passing.
TestDelayedConnectionTeardownTimeoutTrigger can be flaky due to delayed
close repeatedly firing too early.
oschaaf
oschaaf approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question for consideration, but LGTM

test/integration/integration_test.cc Show resolved Hide resolved
@maistra-bot maistra-bot merged commit d3cc852 into maistra:maistra-1.1 Mar 12, 2021
@dmitri-d dmitri-d deleted the fix-test-certs-1.1 branch March 12, 2021 18:23
@maistra-bot
Copy link

@dmitri-d: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
envoy-unit 39d5b37 link /test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

2 similar comments
@maistra-bot
Copy link

@dmitri-d: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
envoy-unit 39d5b37 link /test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maistra-bot
Copy link

@dmitri-d: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
envoy-unit 39d5b37 link /test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dmitri-d pushed a commit to dmitri-d/maistra-envoy that referenced this pull request Apr 20, 2021
Fixes MAISTRA-2202 updated expired certs (maistra#80)
47116ac 
- test/config/integration/certs
 - test/extensions/transport_sockets/tls/test_data

 also a small change in test/integration/integration_test.cc to get
ResponseFramedByConnectionCloseWithReadLimits passing.
TestDelayedConnectionTeardownTimeoutTrigger can be flaky due to delayed
close repeatedly firing too early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwendell jwendell jwendell approved these changes

@oschaaf oschaaf oschaaf approved these changes

Assignees
No one assigned
Labels
okay to merge size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitri-d @maistra-bot @jwendell @oschaaf