MAISTRA-2155 Fix shellcheck errors in Must Gather #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
commented
Mar 2, 2021
brian-avery
approved these changes
Mar 2, 2021
jwendell
requested changes
Mar 2, 2021
There was a problem hiding this comment.
Can you add a prow pre-submit test that runs shellcheck against this file?
In this repo, you'd need to add a lint target in Makefile that runs shellcheck like this: https://github.com/maistra/test-infra/blob/main/Makefile#L39
Then, open a PR in test-infra adding the job.
gather_istio
Outdated
| @@ -133,11 +140,11 @@ function getEnvoyConfigForPodsInNamespace() { | |||
| local logPath=${BASE_COLLECTION_PATH}/namespaces/${podNamespace}/pods/${podName} | |||
| mkdir -p ${logPath} | |||
|
|
|||
| echo "Pilot config for pod ${podName}.${podNamespace} from istiod ${pilotName}.${controlPlaneNamespace}" 2>&1 1>${logPath}/pilotConfiguration | |||
| oc exec ${pilotName} -n ${controlPlaneNamespace} -c discovery -- bash -c "/usr/local/bin/pilot-discovery request GET /debug/config_dump?proxyID=${podName}.${podNamespace}" 2>&1 1>${logPath}/pilotConfiguration | |||
| echo "Pilot config for pod ${podName}.${podNamespace} from istiod ${pilotName}.${controlPlaneNamespace}" > ${logPath}/pilotConfiguration 2>&1 | |||
There was a problem hiding this comment.
nit: Strictly speaking 2>&1 is not necessary, I believe echo will never fail.
There was a problem hiding this comment.
Lol. At least if it does, there are likely bigger issues.
jwendell
approved these changes
Mar 2, 2021
|
In response to a cherrypick label: #13 failed to apply on top of branch "maistra-2.1": |
luksa
added a commit
to luksa/istio-must-gather
that referenced
this pull request
Mar 8, 2021
* Correct use of arrays (SC2178) * Avoid masking return values (SC2155) * Prevent whitespace problems (SC2048) * Ensure errors are written to the file instead of stdout (SC2069) * Double quote to prevent globbing and word splitting (SC2086) * Run ShellCheck on make lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.