Skip to content

Commit

Permalink
OSSM-1397 Add back maistra.io/member-of label when it's removed fro…
Browse files Browse the repository at this point in the history
…m the namespace (#1478)
  • Loading branch information
luksa committed Nov 23, 2023
1 parent 5a72ffc commit 672d3b4
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions pkg/controller/servicemesh/member/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/tools/record"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
Expand Down Expand Up @@ -98,6 +99,35 @@ func add(mgr manager.Manager, r *MemberReconciler) error {
return err
}

// watch namespaces so that the member-of label is re-added when it's removed
err = c.Watch(&source.Kind{Type: &corev1.Namespace{}}, &handler.EnqueueRequestsFromMapFunc{
ToRequests: handler.ToRequestsFunc(func(ns handler.MapObject) []reconcile.Request {
namespace := ns.Object.(*corev1.Namespace)
smmKey := types.NamespacedName{
Namespace: namespace.Name,
Name: common.MemberName,
}

smm := &maistrav1.ServiceMeshMember{}
if err := mgr.GetClient().Get(ctx, smmKey, smm); err != nil {
if !errors.IsNotFound(err) {
log := common.LogFromContext(ctx)
log.Error(err, "Could not get ServiceMeshMember", "ServiceMeshMember", smmKey)
}
return nil
}
return []reconcile.Request{{NamespacedName: smmKey}}
}),
}, predicate.Funcs{
CreateFunc: func(createEvent event.CreateEvent) bool { return false },
UpdateFunc: func(event event.UpdateEvent) bool { return true },
DeleteFunc: func(deleteEvent event.DeleteEvent) bool { return false },
GenericFunc: func(_ event.GenericEvent) bool { return false },
})
if err != nil {
return err
}

// TODO: this needs to be moved outside the controller, since it configures global stuff (and is required by multiple controllers)
err = mgr.GetFieldIndexer().IndexField(ctx, &maistrav1.ServiceMeshMember{}, "spec.controlPlaneRef.namespace", func(obj runtime.Object) []string {
roll := obj.(*maistrav1.ServiceMeshMember)
Expand Down

0 comments on commit 672d3b4

Please sign in to comment.