OSSM-1188 Remove ServiceMeshExtension support #1016
Conversation
| if err := cl.List(ctx, serviceMeshExtensions); err != nil { | ||
| fmt.Println(err) | ||
| if !errors.IsNotFound(err) { | ||
| logger.Error(err, "failed to list ServiceMeshExtensions") |
There was a problem hiding this comment.
it failed because there's no SME CR, so, it's expected and not an error?
There was a problem hiding this comment.
not sure what you mean? the test passes locally
There was a problem hiding this comment.
I mean: trying to list a SME and get a failure should not be logged as an error, should it? If there's no SME CRD in the cluster, for example, an error is expected and desirable, right?
There was a problem hiding this comment.
Also, there's a println hidden in there :D
There was a problem hiding this comment.
I mean: trying to list a SME and get a failure should not be logged as an error, should it? If there's no SME CRD in the cluster, for example, an error is expected and desirable, right?
Hmm in that case you'd be right. We will have to still install the CRD though, as a user might install a pre-2.3 version - and we always install the same set of CRDs for all control plane versions. But I can check for that error
Also, there's a println hidden in there :D
not anymore, I removed that 😉 it's just still visible here for some reason
dgn
force-pushed
the
OSSM-1188
branch
3 times, most recently
from
9e6284b
to
939771e
Compare
dgn
force-pushed
the
OSSM-1188
branch
2 times, most recently
from
2857ce5
to
218babe
Compare
This removes the wasm-cache chart from the 2.3 helm charts. It also adds upgrade validation: upgrading to v2.3 will fail if you have existing SMEs in your member namespaces. This check however is only performed when upgrading, not when creating new SMCPs, reasons being: