[maistra-2.4] OSSM-1330: Fix integration with cert-manager/istio-csr #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix integration with cert-manger-istio-csr Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Fix Helm value for istio-csr Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Change structure of SecretCABundleSource Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Refactor webhookca controller Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Refactor controller tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Refactor controller tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Refactor controller tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Refactor controller tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Remove fields pilotSecretName and rootCAConfigMapName from cert-manager configuration Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Add missing command to create bookinfo project Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Add instructions how to manually fix integration with cert-manager in already released versions Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Use intermediate certificate in istiod webhooks Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Revert removal of pilotSecretName and rootCAConfigMapName Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Store secret names and keys in an array instead of a map to iterate in deterministic order Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Improve documentation Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Respect customized rootCAConfigMapName Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Remove verification step with istioctl Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Clarify that istiod-tls is a TLS secret Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
…maistra#1110) Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
|
@jewertow: This pull request references OSSM-1330 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
luksa
approved these changes
Feb 13, 2023
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #1101 and #1110.