Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-3259 Move controlPlaneMode out of SMCP.spec.techPreview #1126

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Mar 1, 2023

No description provided.

@luksa luksa force-pushed the OSSM-3259 branch 5 times, most recently from b983405 to 7733c54 Compare March 1, 2023 13:56
Copy link
Member

@jewertow jewertow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't we agree that SMMR will be optional in cluster-wide mode?

pkg/controller/versions/util.go Show resolved Hide resolved
// other version.
AtLeast(other Version) bool
// LessThan returns true if this version is less than the specified version.
LessThan(other Version) bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed these functions recently. 👍

@luksa
Copy link
Contributor Author

luksa commented Mar 17, 2023

LGTM, but didn't we agree that SMMR will be optional in cluster-wide mode?

It will. This is just the first commit. As soon as this one merges, I'll submit two more.

@maistra-bot maistra-bot merged commit ecd25d5 into maistra:maistra-2.4 Mar 17, 2023
@luksa luksa deleted the OSSM-3259 branch November 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants