Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3235 Ensure operator can't deadlock because istiod isn't running #1155

Merged
merged 1 commit into from
Apr 11, 2023
Merged

OSSM-3235 Ensure operator can't deadlock because istiod isn't running #1155

merged 1 commit into from
Apr 11, 2023

Commits on Apr 6, 2023

  1. OSSM-3235 Ensure operator can't deadlock because istiod isn't running 

    If istiod isn't running, but the validating webhook configuration resource is in place, the operator may not be able to reconcile the SMCP and reset istiod.

Here, we configure the webhook with an objectSelector that excludes resources with the `maistra-version` label. All resources created by the operator for the SMCP contain this label and thus don't trigger the webhook. This allows the operator to complete the reconciliation even if the webhook is offline.
    @luksa
    luksa committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3443d1a View commit details
    Browse the repository at this point in the history