OSSM-1698: Don't install istio-cni on nodes with label maistra.io/exclude-cni: 'true'
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore-cni Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
jewertow
changed the title
maistra.io/ignore-cnimaistra.io/ignore-cni: 'true'
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
jewertow
changed the title
maistra.io/ignore-cni: 'true'maistra.io/exclude-cni: 'true'
luksa
approved these changes
Nov 2, 2023
|
We should submit this upstream (with |
|
Does upstream need this? I think the CNI node affinity can already be configured via |
@jwendell we already did it one year ago :D |
We can't cherry-pick it, because we don't use upstream istio-cni chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.