Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-5319 Clean up chart rendering #1428

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Nov 3, 2023

No description provided.

@openshift-ci openshift-ci bot added the size/M label Nov 3, 2023
@jwendell
Copy link
Member

jwendell commented Nov 3, 2023

It looks like because the test doesn't deploy via OLM, the arguments for the default profiles are not passed to the operator, thus it didn't apply the openshift profile, making istio-cni pod not exist...

@luksa luksa force-pushed the OSSM-5319 branch 4 times, most recently from 0668fae to 719ac78 Compare November 6, 2023 13:34
@openshift-ci openshift-ci bot added size/L and removed size/M labels Nov 6, 2023
@luksa luksa added tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. and removed okay to merge labels Nov 6, 2023
@luksa luksa requested a review from jwendell November 6, 2023 17:15
@openshift-merge-bot openshift-merge-bot bot merged commit af156c5 into maistra:maistra-3.0 Nov 6, 2023
8 checks passed
@luksa luksa deleted the OSSM-5319 branch November 10, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge size/L tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants