OSSM-5386 Add meshConfig to values schema #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
commented
Nov 16, 2023
| type: string | ||
| type: object |
There was a problem hiding this comment.
This is probably wrong, but is caused by the fact that tag is not defined as a string, but as a google.protobuf.Value:
There was a problem hiding this comment.
It looks like a google.protobuf.Value can be any type. I don't really know which OpenAPIv3 type fits here
luksa
commented
Nov 16, 2023
Comment on lines
+604
to
+605
| revisionTags: | ||
| type: string |
There was a problem hiding this comment.
This should be an array. Will be fixed in a different PR.
luksa
commented
Nov 16, 2023
Comment on lines
-127
to
-128
| set_values "${proto_file}" | ||
|
|
There was a problem hiding this comment.
Don't know why this was called. It's already called in the main function, so I don't think it needs to be called here (it gets called for each top-level value that the set_values function finds when it's called in the main function).
bmangoen
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.