OSSM-5398 Add test checking spec.values validation #1491
Conversation
|
/retest |
1 similar comment
|
/retest |
| "pilot":{"image":"` + pilotImage + `"}, | ||
| "istio_cni":{"enabled":true} | ||
| }`), | ||
| Values: istioValues, |
There was a problem hiding this comment.
Not sure if it's a good idea to change the values of the existing test. Better to add a new test.
| }`) | ||
|
|
||
| istioValues := []byte(`{ | ||
| "donotexist": "shouldbeomitted", |
There was a problem hiding this comment.
This value should throw an error instead of being silently ignored.
There was a problem hiding this comment.
Actually, this value is omitted without throwing an error by the controller-runtime client but only as an info warning INFO KubeAPIWarningLogger unknown field "spec.values.donotexist". Should we try to catch this as an error?
|
@bmangoen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.