OSSM-5444: Fix mapping spec.tracing.type: None
to helm values
#1558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing zipkin extension provider, I noticed that we incorrectly handle
None
tracing type and as a result istio proxies receive incorrect default config:and therefore pilot-agent overwrites
tracing: null
with the default zipkin address, while the expected config is:Actually, it does not affect tracing, because when a
Telemetry
config is applied to a proxy, the default tracing address is not used by Envoy, but it might be confusing when debugging tracing issues.