MAISTRA-2007 Use self-signed cert for webhook caBundle if present #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
CABundleSourceso that it'll first check whether there's acacertssecret and use that if possible. If it's not present, it will use theistio-ca-secretjust as before. I verified that this matches the behaviour ofistiod: it will usecacertsif present, and if not it will create the self-signedistio-ca-secretsecret.I had to refactor quite a bit of code to make this work, most notably the
WebhookCABundleManagerdoesn't know how to retrieve caBundles from a source anymore, but that logic has been moved into theCaBundleSourceitself. This allows for a more flexible behaviour, we could e.g. implement a dynamic source in the future that fetches a ConfigMap or Secret, depending on SMCP config.