MAISTRA-2023 Add support for specifying kiali resource and scheduling constraints #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
force-pushed
the
MAISTRA-2023
branch
3 times, most recently
from
50ff6ec
to
2f3ffe9
Compare
knrc
suggested changes
Apr 9, 2021
| if nodeSelector != nil { | ||
| if values, err := toValues(nodeSelector); err == nil { | ||
| if len(values) > 0 { | ||
| if err := setHelmValue(kialiValues, "deployment.nodeSelector", values); err != nil { |
There was a problem hiding this comment.
@luksa should this not be node_selector? See
{% if kiali_vars.deployment.node_selector|length > 0 %}
nodeSelector:
{{ kiali_vars.deployment.node_selector | to_nice_yaml(indent=0) | trim | indent(8) }}
{% else %}
nodeSelector: null
{% endif %}
There was a problem hiding this comment.
never mind, I see we have used nodeSelector in our template but are setting node_selector
There was a problem hiding this comment.
Yeah, unfortunately, Kiali uses the node_selector notation for its values, whereas SMCP uses nodeSelector. It was hard for me to decide where to perform the switch, but the existing code in conversion/kiali.go already used the latter format, so I kept things consistent.
knrc
approved these changes
Apr 9, 2021
jwendell
approved these changes
Apr 12, 2021
luksa
added a commit
to luksa/istio-operator
that referenced
this pull request
Aug 30, 2021
maistra-bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
mtturcsik
pushed a commit
to mtturcsik/istio-operator
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.