Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-2302: Bump openshift dependency #709

Closed
wants to merge 1 commit into from

Conversation

jwendell
Copy link
Member

@jwendell jwendell commented May 5, 2021

This is needed because maistra/api Status object depends
on Operator's version package. This needs to be fixed as
part of https://issues.redhat.com/browse/MAISTRA-2331.

Without this we get this go mod error:

github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found

This is needed because maistra/api Status object depends
on Operator's version package. This needs to be fixed as
part of https://issues.redhat.com/browse/MAISTRA-2331.

Without this we get this go mod error:
```
github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```
@maistra-bot
Copy link
Contributor

@jwendell: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
istio-operator_gen-check c947864 link /test istio-operator_gen-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rcernich
Copy link
Contributor

rcernich commented May 5, 2021

Shouldn't we do this when we migrate to using maistra/api? I don't understand the need for this at this time. I don't think maistra/api should depend on maistra/istio-operator at all, as it will create a circular dependency between api and operator.

@jwendell
Copy link
Member Author

jwendell commented May 5, 2021

I don't think maistra/api should depend on maistra/istio-operator at all, as it will create a circular dependency between api and operator.

Yeah, me too. This is described in MAISTRA-2331. I believe this should be fixed as part of that ticket.

@jwendell
Copy link
Member Author

jwendell commented May 5, 2021

Ok, I've removed that circular dependency for now, we will need to move it from status API to operator code base. It's kind of a static method that's only relevant to the operator, should stay in operator codebase:

return ComposeReconciledVersion(version.Info.Version, generation)

So, we are safe to close this PR. maistra/api doesn't depend on operator anymore.

@jwendell jwendell closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants