Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAISTRA-2493 No need to turn ingressControllerMode=off manually #767

Merged
merged 1 commit into from
Jul 9, 2021
Merged

MAISTRA-2493 No need to turn ingressControllerMode=off manually #767

merged 1 commit into from
Jul 9, 2021

Conversation

shamsher31
Copy link

@shamsher31 shamsher31 requested a review from luksa July 9, 2021 07:40
@shamsher31 shamsher31 self-assigned this Jul 9, 2021
@shamsher31
Copy link
Author

This is going to build once #766 is merged.

jwendell
jwendell reviewed Jul 9, 2021
View reviewed changes
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Can you explain it in the commit message? Can you create a Jira for it?

@shamsher31
Copy link
Author

/test istio-operator_gen-check

@shamsher31
Copy link
Author

Why? Can you explain it in the commit message? Can you create a Jira for it?

@jwendell Added JIRA for this https://issues.redhat.com/browse/MAISTRA-2493

@shamsher31 shamsher31 requested a review from jwendell July 9, 2021 11:15
@jwendell jwendell changed the title No need to turn ingressControllerMode=off manually MAISTRA-2493 No need to turn ingressControllerMode=off manually Jul 9, 2021
@maistra-bot maistra-bot merged commit 08f00d4 into maistra:maistra-2.1 Jul 9, 2021
@shamsher31 shamsher31 deleted the remove-ingress-off branch July 9, 2021 12:05
mtturcsik pushed a commit to mtturcsik/istio-operator that referenced this pull request Dec 20, 2021
@mtturcsik
No need to turn ingressControllerMode=off manually (maistra#767)
b1e0ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwendell jwendell jwendell approved these changes

@luksa luksa luksa approved these changes

Assignees

@shamsher31 shamsher31

Labels
okay to merge size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shamsher31 @jwendell @luksa @maistra-bot