MAISTRA-2627 Remove namespace field from istiod-internal ClusterRoleBinding definition #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inding definition
dgn
approved these changes
Aug 25, 2021
jwendell
approved these changes
Aug 25, 2021
dgn
reviewed
Aug 25, 2021
| @@ -2,7 +2,6 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRoleBinding | |||
| metadata: | |||
| name: istiod-internal-{{ .Values.revision | default "default" }}-{{ .Release.Namespace }} | |||
| namespace: {{ .Release.Namespace }} | |||
There was a problem hiding this comment.
This is going to be overwritten until the 2.0 PR goes in I guess
There was a problem hiding this comment.
Shoud we just not make the change here?
There was a problem hiding this comment.
That's why I'll wait for the 2.0 PR to be merged before merging this. If I remove this change and merge this 2.1 PR and then the 2.0 PR, we'll then get gen-check errors in all other 2.1 PRs until we run make gen. I thought just adding this change here was simpler.
|
/test istio-operator_gen-check |
mtturcsik
pushed a commit
to mtturcsik/istio-operator
that referenced
this pull request
Dec 20, 2021
…inding definition (maistra#824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.