Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-2637 Disable ingress controller in istiod #833

Merged
merged 1 commit into from Sep 3, 2021

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Sep 3, 2021

No description provided.

Copy link
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're also adding it to the 2.0 strategy - might that break anyone?

@luksa
Copy link
Contributor Author

luksa commented Sep 3, 2021

I'm in the process of making sure 2.0 works on OpenShift 4.9+ and I found that even 2.1 doesn't work there. This needs to go into 2.0, too. Not sure if anyone needs this. If they do, maybe we need to only disable it in 4.9+ clusters.

@maistra-bot maistra-bot merged commit c737e36 into maistra:maistra-2.1 Sep 3, 2021
@luksa luksa deleted the MAISTRA-2637 branch September 3, 2021 19:55
luksa added a commit to luksa/istio-operator that referenced this pull request Sep 7, 2021
mtturcsik pushed a commit to mtturcsik/istio-operator that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants