Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-1239 add support for operators.openshift.io/valid-subscription csv annotation #899

Merged
merged 3 commits into from Mar 23, 2022

Conversation

rcernich
Copy link
Contributor

No description provided.

sed -i -e 's/__JAEGER_STORAGE__/'${JAEGER_STORAGE}'/' ${csv_path}
sed -i -e 's/__JAEGER_TEMPLATE__/'${JAEGER_TEMPLATE}'/' ${csv_path}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

…sv annotation

Signed-off-by: rcernich <rcernich@redhat.com>
Signed-off-by: rcernich <rcernich@redhat.com>
Signed-off-by: rcernich <rcernich@redhat.com>
@jwendell jwendell mentioned this pull request Mar 23, 2022
Copy link
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll just mention that currently we maintain a copy of the CSV file in the distgit repo until OSSM-1148 is fixed. that doesn't invalidate this PR though

@maistra-bot maistra-bot merged commit 82f1a9c into maistra:maistra-2.2 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants