MAISTRA-1627, MAISTRA-1660: Fix lint, gen-check and integration test failures #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add version label to metric Signed-off-by: Liam White <liam@tetrate.io> * back to gauge Signed-off-by: Liam White <liam@tetrate.io> Co-authored-by: Liam White <liam@tetrate.io>
…ease-1.6 (#25426)
knrc
approved these changes
Jul 10, 2020
|
/retest |
brian-avery
reviewed
Jul 10, 2020
brian-avery
reviewed
Jul 10, 2020
brian-avery
suggested changes
Jul 10, 2020
knrc
suggested changes
Jul 10, 2020
…n upgrade with dry run option (#25207) (#25425) Co-authored-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
|
/retest |
1 similar comment
|
/retest |
dgn
approved these changes
Jul 15, 2020
Co-authored-by: Oliver Liu <yonggangl@google.com>
|
Fixed the Copyright |
|
/test lint |
…ease-1.6 (#25553)
|
/test unit |
|
/test integration |
* fixed typo * fix the default behavior Co-authored-by: zhengzhey <zhengzhey@google.com>
…o MAISTRA-1627-v2 This brings in the fix for MAISTRA-1660.
|
All tests pass now. Turns out integration tests had an issue. Created MAISTRA-1660 for that. |
|
@jwendell This PR seems to include more than just lint and gen-check failures, can these be separated out into individual PRs? |
|
no. If we split it, tests will fail for both PR's. Unless we force-merge them. |
|
@jwendell please create a second JIRA to cover the additional work and include it in the description of this PR, we should not be sneaking in additional changes just for expedience. |
knrc
suggested changes
Jul 16, 2020
jwendell
changed the title
|
@knrc done |
knrc
approved these changes
Jul 16, 2020
brian-avery
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers a bunch of fixes for failures:
make lintworks (MAISTRA-1627)make gen-checkworks (MAISTRA-1627)For the last item we had to bring the fix from upstream release-1.6 branch, hence some commits not related to this PR itself. This is to avoid cherry-picking just one commit and have to resolve conflicts later.