MAISTRA-1739 Fix validation of AuthorizationPolicy fields #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwendell
reviewed
Aug 7, 2020
|
Good point. I added a test |
|
/retest |
luksa
approved these changes
Aug 12, 2020
pkg/config/security/security.go
Outdated
| attrConnSNI = "connection.sni" // server name indication, e.g. "www.example.com". | ||
| attrExperimental = "experimental.envoy.filters." | ||
| attrRequestHeader = "request.headers" // header name is surrounded by brackets, e.g. "request.headers[User-Agent]". | ||
| attrRequestHeaderRegex = "request.regex.headers" // header name is surrounded by brackets, e.g. "request.headers[User-Agent]". |
There was a problem hiding this comment.
Comment is the same as in the previous line - should be request.regex.headers[User-Agent]
It would previously detect request.regex.headers as invalid, even though it is supported.
|
/retest |
jwendell
approved these changes
Aug 18, 2020
dgn
added a commit
to dgn/istio-maistra
that referenced
this pull request
Nov 17, 2020
It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157)
dgn
added a commit
to dgn/istio-maistra
that referenced
this pull request
Nov 17, 2020
It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157)
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2020
It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (#157)
brian-avery
pushed a commit
to brian-avery/istio-1
that referenced
this pull request
Jan 21, 2021
Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157)
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Jun 11, 2021
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Jun 15, 2021
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Jun 16, 2021
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Jun 30, 2021
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 2, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 28, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Mar 1, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
pushed a commit
to jewertow/istio
that referenced
this pull request
Jun 20, 2022
…stra#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
maistra-bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
… (#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 23, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 24, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 25, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 25, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 25, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 29, 2022
…stra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 29, 2022
…ers (maistra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 29, 2022
…ers (maistra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Aug 29, 2022
…ers (maistra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
maistra-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
…ers (#236) (#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
bartoszmajsak
pushed a commit
to bartoszmajsak/istio
that referenced
this pull request
Dec 21, 2022
…ers (maistra#236) (maistra#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
maistra-bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
…ers (#236) (#544) (#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Sep 1, 2023
…ers (maistra#236) (maistra#544) (maistra#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
jewertow
added a commit
to jewertow/istio
that referenced
this pull request
Sep 3, 2023
…ers (maistra#236) (maistra#544) (maistra#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (maistra#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (maistra#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 4, 2023
…ers (#236) (#544) (#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would previously detect the field
request.regex.headersas invalid, even though it is supported.I'm adding a hold as this will only go into 1.1.8