-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce xns-informer #370
Closed
luksa
wants to merge
1
commit into
maistra:maistra-2.1-istio-1.9
from
luksa:maistra-2.1-istio-1.9-pr2
Closed
Introduce xns-informer #370
luksa
wants to merge
1
commit into
maistra:maistra-2.1-istio-1.9
from
luksa:maistra-2.1-istio-1.9-pr2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
force-pushed
the
maistra-2.1-istio-1.9-pr2
branch
from
June 15, 2021 08:04
1dfd870
to
a7cd09d
Compare
MAISTRA-2051: Add xns-informer for Kubernetes types (maistra#223) * vendor: Add github.com/maistra/xns-informer * Update mirrored licenses to fix gen-check * MAISTRA-2051: Add xns-informer for Kubernetes types This integrates the xns-informer library for multi-namespace support, but only for core Kubernetes types. The informers are hard-coded to watch all namespaces here. The integration with MemberRoll will come in a follow-up. MAISTRA-2051 Add xns-informer for Istio types (maistra#221) MAISTRA-2051: Add MemberRollController (maistra#227) * MAISTRA-2051: Add MemberRollController Includes the following: * 75742b0 - Add Makefile for Maistra client generation This adds a Makefile with tasks for generating the Maistra specific clients. It is adapted from the one in the Istio client-go repository. * 5f8562c - Add MemberRollController Squashed commit, consisting of: * MAISTRA-417: Add MemberRollController * MAISTRA-450: Switch across to ConfiguredMembers and check existing config for changes * MAISTRA-1005 Do not expect namespaces to have a stable ordering The clients have also been regenerated. * 1b7a89d - Add missing licenses * fe2f8cd - Fix Copyright holder * 06ea2db - MAISTRA-1666: Add `go mod vendor` as part of `make gen` This is to make sure all PR's will have an updated vendor directory. The `gencheck` prow job will ensure that. * MAISTRA-2051: Update MemberRollController for xns-informers * MAISTRA-2051: Add AddMemberRoll to kube client * MAISTRA-2051: Configure MemberRoll controller in istiod MAISTRA-2051: Add xns-informer for Service APIs (maistra#229) * MAISTRA-2051: Update xns-informers * MAISTRA-2051: Add xns-informer for Service APIs MAISTRA-2051: Use shared Kubernetes client in galley (maistra#241) This moves galley to the shared Kubernetes client, which will let it use xns-informers for multi-namespace support like everything else. MAISTRA-2051: Update xns-informers to latest (maistra#252) * MAISTRA-2051: Reset Kubernetes client to release-1.8 state * MAISTRA-2051: Use xns-informers in Kubernetes client * MAISTRA-2051: Un-skip tests with xns-informers issues These tests were skipped because of issues with xns-informers, which have now been solved. They should no longer be skipped. * MAISTRA-2051: Update xns-informers to latest * MAISTRA-2051: Skip problematic integration test: TestDashboard MAISTRA-2051: Use MultiNamespaceInformer in galley (maistra#254) * Revert "MAISTRA-2051: Use shared Kubernetes client in galley (maistra#241)" This reverts commit 0b1567a. * MAISTRA-2051: Use MultiNamespaceInformer in galley This is a rework of the previous change that used the central Kubernetes client in Galley. The watchers in Galley manage stopping and starting individual informers, which doesn't work well with the factory returning cached informers. This creates multi-namespace informers individually instead of using the central factory. It's also a much smaller change overall and doesn't affect the tests. * MAISTRA-2051: Add GetMemberRoll method to Kubernetes client * MAISTRA-2051: Integrate MemberRoll with Galley This configures the mulit-namespace aware infomers in Galley to respond to changes in the set of namespaces via the MemberRoll. This includes parts of the following: - 4b70b8d MAISTRA-1895 Add option to enable/disable CRD scan - 6e8019e MAISTRA-1968 allow analyzer to work with multi list watcher MAISTRA-1724: Don't watch namespaces if MemberRoll is used (maistra#257) Rewrite of the following for Maistra 2.1 / Istio 1.8 rebase: a161a53 - MAISTRA-1724 Don't watch namespaces if MRC is used (maistra#161) MAISTRA-1755: invoke UpdateNamespaces() as part of MemberRollController.Register() Cherry-pick of f0eed15 for Maistra 2.1 / Istio 1.8 rebase. MAISTRA-1724: Better hanlde deletion in NamespaceController MAISTRA-2153: Disable namespace informer if MemberRoll is used (maistra#283) This causes istiod to skip creating the namespace informer in the Kubernetes service registry controller if a MemberRoll is specified, because Maistra cannot read namespace objects. This will affect the behavior of multi-network deployments that do not use mesh networks for configuration, i.e. a namespace cannot be labeled with a default network now. MAISTRA-2197: Push first update when cache is warm (maistra#294) Change SMMR Controller behavior to only send the first update to listeners when it has a list of members ready. In other words, when cache is synced. Before this, the first update was sent with only one hardcoded member: The control plane namespace. Now it is sent with the full list of SMMR members. While on that, switch to our own log scope, to facilitate debugging. Manual cherry pick of maistra#291 MAISTRA-2233: Start xns-informers with empty namespace set (maistra#303) The multi-namespace informers created by xns-informers default to watching all namespaces to match upstream behaviour. This causes permissions issues in Maistra because they will do this until the first update from the MemberRoll controller sets the correct set of namespaces on each informer. We should instead explicitly configure them with an empty set of namespaces at startup. MAISTRA-2234: Seed MemberRoll listeners with system namespace (maistra#302) The MemberRoll controller was changed in MAISTRA-2197 to not send the initial update with just the system namespace to all listeners. This can be a problem when the user hasn't created an SMMR resource yet, because any listeners registered before the caches sync may never get an update informing them to watch the system namespace. This attempts to work around the issue by having all listeners individually wait on the caches to sync, then seed just the system namespace if no SMMR resource is found. MAISTRA-2271: Update xns-informers to fix delete events issue (maistra#315) This updates xns-informers to include a fix for sending delete events for all objects when a namespace is no longer watched. See: maistra/xns-informer#12
luksa
force-pushed
the
maistra-2.1-istio-1.9-pr2
branch
from
June 15, 2021 08:59
a7cd09d
to
1ced830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAISTRA-2051: Add xns-informer for Kubernetes types (#223)
vendor: Add github.com/maistra/xns-informer
Update mirrored licenses to fix gen-check
MAISTRA-2051: Add xns-informer for Kubernetes types
This integrates the xns-informer library for multi-namespace support,
but only for core Kubernetes types. The informers are hard-coded to
watch all namespaces here. The integration with MemberRoll will come
in a follow-up.
MAISTRA-2051 Add xns-informer for Istio types (#221)
MAISTRA-2051: Add MemberRollController (#227)
Includes the following:
This adds a Makefile with tasks for generating the Maistra specific
clients. It is adapted from the one in the Istio client-go repository.
Squashed commit, consisting of:
MAISTRA-417: Add MemberRollController
MAISTRA-450: Switch across to ConfiguredMembers and check existing
config for changes
MAISTRA-1005 Do not expect namespaces to have a stable ordering
The clients have also been regenerated.
1b7a89d - Add missing licenses
fe2f8cd - Fix Copyright holder
06ea2db - MAISTRA-1666: Add
go mod vendor
as part ofmake gen
This is to make sure all PR's will have an updated
vendor directory. The
gencheck
prow job will ensure that.MAISTRA-2051: Update MemberRollController for xns-informers
MAISTRA-2051: Add AddMemberRoll to kube client
MAISTRA-2051: Configure MemberRoll controller in istiod
MAISTRA-2051: Add xns-informer for Service APIs (#229)
MAISTRA-2051: Update xns-informers
MAISTRA-2051: Add xns-informer for Service APIs
MAISTRA-2051: Use shared Kubernetes client in galley (#241)
This moves galley to the shared Kubernetes client, which will let it
use xns-informers for multi-namespace support like everything else.
MAISTRA-2051: Update xns-informers to latest (#252)
MAISTRA-2051: Reset Kubernetes client to release-1.8 state
MAISTRA-2051: Use xns-informers in Kubernetes client
MAISTRA-2051: Un-skip tests with xns-informers issues
These tests were skipped because of issues with xns-informers, which
have now been solved. They should no longer be skipped.
MAISTRA-2051: Update xns-informers to latest
MAISTRA-2051: Skip problematic integration test: TestDashboard
MAISTRA-2051: Use MultiNamespaceInformer in galley (#254)
This reverts commit 0b1567a.
This is a rework of the previous change that used the central
Kubernetes client in Galley. The watchers in Galley manage stopping
and starting individual informers, which doesn't work well with the
factory returning cached informers. This creates multi-namespace
informers individually instead of using the central factory. It's
also a much smaller change overall and doesn't affect the tests.
MAISTRA-2051: Add GetMemberRoll method to Kubernetes client
MAISTRA-2051: Integrate MemberRoll with Galley
This configures the mulit-namespace aware infomers in Galley to
respond to changes in the set of namespaces via the MemberRoll.
This includes parts of the following:
MAISTRA-1724: Don't watch namespaces if MemberRoll is used (#257)
Rewrite of the following for Maistra 2.1 / Istio 1.8 rebase:
a161a53 - MAISTRA-1724 Don't watch namespaces if MRC is used (#161)
MAISTRA-1755: invoke UpdateNamespaces() as part of MemberRollController.Register()
Cherry-pick of f0eed15 for Maistra 2.1 / Istio 1.8 rebase.
MAISTRA-1724: Better hanlde deletion in NamespaceController
MAISTRA-2153: Disable namespace informer if MemberRoll is used (#283)
This causes istiod to skip creating the namespace informer in the
Kubernetes service registry controller if a MemberRoll is specified,
because Maistra cannot read namespace objects. This will affect the
behavior of multi-network deployments that do not use mesh networks
for configuration, i.e. a namespace cannot be labeled with a default
network now.
MAISTRA-2197: Push first update when cache is warm (#294)
Change SMMR Controller behavior to only send the first update to
listeners when it has a list of members ready. In other words, when
cache is synced.
Before this, the first update was sent with only one hardcoded member:
The control plane namespace. Now it is sent with the full list of SMMR
members.
While on that, switch to our own log scope, to facilitate debugging.
Manual cherry pick of #291
MAISTRA-2233: Start xns-informers with empty namespace set (#303)
The multi-namespace informers created by xns-informers default to
watching all namespaces to match upstream behaviour. This causes
permissions issues in Maistra because they will do this until the
first update from the MemberRoll controller sets the correct set of
namespaces on each informer. We should instead explicitly configure
them with an empty set of namespaces at startup.
MAISTRA-2234: Seed MemberRoll listeners with system namespace (#302)
The MemberRoll controller was changed in MAISTRA-2197 to not send the
initial update with just the system namespace to all listeners. This
can be a problem when the user hasn't created an SMMR resource yet,
because any listeners registered before the caches sync may never get
an update informing them to watch the system namespace.
This attempts to work around the issue by having all listeners
individually wait on the caches to sync, then seed just the system
namespace if no SMMR resource is found.
MAISTRA-2271: Update xns-informers to fix delete events issue (#315)
This updates xns-informers to include a fix for sending delete events
for all objects when a namespace is no longer watched.
See: maistra/xns-informer#12
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.