OSSM-742 Improve Maistra container images build (for maistra-2.3) #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION
jwendell
approved these changes
Sep 26, 2022
|
@bmangoen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bartoszmajsak
pushed a commit
to bartoszmajsak/istio
that referenced
this pull request
Nov 22, 2022
…istra#606) * OSSM-742 Improve Maistra container images build (maistra#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts
maistra-bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (#606) * OSSM-742 Improve Maistra container images build (#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts * chore: updates image labels to reflect actual targeted versions * chore: removes vendor left-overs Co-authored-by: bmangoen <bmangoen@gmail.com>
jewertow
pushed a commit
to jewertow/istio
that referenced
this pull request
Sep 1, 2023
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (maistra#606) * OSSM-742 Improve Maistra container images build (maistra#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts * chore: updates image labels to reflect actual targeted versions * chore: removes vendor left-overs Co-authored-by: bmangoen <bmangoen@gmail.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 4, 2023
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (#606) * OSSM-742 Improve Maistra container images build (#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts * chore: updates image labels to reflect actual targeted versions * chore: removes vendor left-overs Co-authored-by: bmangoen <bmangoen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
With this change, it will be possible to build and push the Maistra container images with
maketargets.There are adaptabilities done because of the Istio upstream build process changes
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.