OSSM-755: Fix TLS certificates used in security tests #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
approved these changes
Oct 19, 2022
jewertow
changed the title
jewertow
force-pushed
the
OSSM-755-egress-tls
branch
from
efd2f9f
to
2e7ebc7
Compare
|
Good catch! |
jewertow
force-pushed
the
OSSM-755-egress-tls
branch
from
2e7ebc7
to
780f978
Compare
jewertow
force-pushed
the
OSSM-755-egress-tls
branch
2 times, most recently
from
7f2eb3f
to
cb79a81
Compare
|
I regenerated all certificates for the sake of consistency, because all of them use the same root-cert.pem. |
jewertow
changed the title
|
Does it make sens to submit this upstream as well, so that we reduce our differences on next rebase? I'd say it's useful as it fixes an issue when running in a different environment (newer openssl) and doesn't break any existent behavior. |
Integration tests for features "security.egress.tls.*" and "security.peer.file-mounted-certs" were failing, because of failing TLS handshake with an alert message "UNKNOWN CA (48)". The reason of this failure is that certificates used in those tests don't pass verification when OpenSSL 1.1.1k or higher is used. Those certificates pass verification on Ubuntu 20.04 which delivers OpenSSL 1.1.1f 31 Mar 2020, but do not pass on CentOS Stream 8 or RHEL 8.6 which deliver OpenSSL 1.1.1k FIPS 25 Mar 2021. I noticed that root-cert.pem and cert-chain.pem had specified the same common name, so as a workaround I added SAN as a prefix to the common name in the cert-chain.pem. Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
jewertow
force-pushed
the
OSSM-755-egress-tls
branch
from
c2762cf
to
d0d66b7
Compare
|
Yes, I submitted a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out that certificates used in
security.egress.tls.*andsecurity.peer.file-mounted-certstests don't pass verification when OpenSSL 1.1.1k and higher is used. For example, those certificates pass verification on Ubuntu 20.04 which deliversOpenSSL 1.1.1f 31 Mar 2020, but do not pass on CentOS Stream 8 or RHEL 8 which deliverOpenSSL 1.1.1k FIPS 25 Mar 2021.I noticed that root-cert.pem and cert-chain.pem have specified the same common name, so as a workaround I added SAN as a prefix to CN in the cert-chain.pem. Without this change, a TLS handshake fail with an alert message "UNKNOWN CA (48)".