Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-1689 Simplify IOR #747

Merged
merged 53 commits into from
Mar 22, 2023
Merged

OSSM-1689 Simplify IOR #747

merged 53 commits into from
Mar 22, 2023

Commits on Mar 21, 2023

  1. Rework IOR initialization 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ba731e7 View commit details
    Browse the repository at this point in the history

  2. Remove initialSync 

    `initialSync` is not needed.

- During boostrap, `SetNamesapces`is always called with no namespaces.
- When removing or adding a namespace, the underlaying informer will
  trigger an `ADD` event for all resources the informer watches

Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    55fd7d6 View commit details
    Browse the repository at this point in the history

  3. DIsable TestPref 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    12aef38 View commit details
    Browse the repository at this point in the history

  4. Rename 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e9b0157 View commit details
    Browse the repository at this point in the history

  5. Call findService once for each gateway 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6d59bd3 View commit details
    Browse the repository at this point in the history

  6. Use original host to generate Route name 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    624d514 View commit details
    Browse the repository at this point in the history

  7. Skip duplicate update test 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3efe45d View commit details
    Browse the repository at this point in the history

  8. Improve concurrency test 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    a5f1252 View commit details
    Browse the repository at this point in the history

  9. Introduce update Route on Gateway update 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3a3d332 View commit details
    Browse the repository at this point in the history

  10. Fix data race 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    96f85ae View commit details
    Browse the repository at this point in the history

  11. Format and lint 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ab47b49 View commit details
    Browse the repository at this point in the history

  12. Respect log level 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cbb4bf7 View commit details
    Browse the repository at this point in the history

  13. Refactor IOR 

    - `gatawayMap` is removed. `Routes` are retrived via API.
-  `reconcileGateway` is used to achieve the desired state.
- `processEvent` will only process the latest and try to abort early.

Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1d8ef68 View commit details
    Browse the repository at this point in the history

  14. Remove unused functions 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    828d04a View commit details
    Browse the repository at this point in the history

  15. Use Lister for finding target service 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1942ac9 View commit details
    Browse the repository at this point in the history

  16. Start IOR before kube client 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    45e0ba7 View commit details
    Browse the repository at this point in the history

  17. Remove unused properties 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ca74c61 View commit details
    Browse the repository at this point in the history

  18. Rework test initialization 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d16b058 View commit details
    Browse the repository at this point in the history

  19. Log correct debug information 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    b16cff0 View commit details
    Browse the repository at this point in the history

  20. Remove unnecessary parameters 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0c65148 View commit details
    Browse the repository at this point in the history

  21. Remove ResourceVersion usage 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    594997f View commit details
    Browse the repository at this point in the history

  22. Avoid deletion of a route when failing to update 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    db9994d View commit details
    Browse the repository at this point in the history

  23. Update FakeRouter to record API call counts 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d1cba59 View commit details
    Browse the repository at this point in the history

  24. Rework initialization 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    267c755 View commit details
    Browse the repository at this point in the history

  25. Keep startup process order consistent 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    eddd8c3 View commit details
    Browse the repository at this point in the history

  26. Fix creating matching service 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    203e223 View commit details
    Browse the repository at this point in the history

  27. Test IOR to be idempotent 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0abdde8 View commit details
    Browse the repository at this point in the history

  28. Remove unused parameters 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3d993c2 View commit details
    Browse the repository at this point in the history

  29. Rename symbol 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    fab5517 View commit details
    Browse the repository at this point in the history

  30. Remove used struct 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    4de56d3 View commit details
    Browse the repository at this point in the history

  31. Improve styling and wording 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    b5342ad View commit details
    Browse the repository at this point in the history

  32. Add support list across namespaces in faker 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7dc9121 View commit details
    Browse the repository at this point in the history

  33. Lint and format 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e809f88 View commit details
    Browse the repository at this point in the history

  34. Introduce Openshift Route informer 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    283d7ca View commit details
    Browse the repository at this point in the history

  35. Lint 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3b336b2 View commit details
    Browse the repository at this point in the history

  36. Run make gen 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ebcee30 View commit details
    Browse the repository at this point in the history

  37. Fix data race 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    65ebd77 View commit details
    Browse the repository at this point in the history

  38. Fix test data race 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9b0f2e3 View commit details
    Browse the repository at this point in the history

  39. Lint 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    71b314b View commit details
    Browse the repository at this point in the history

  40. Rename variables 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ce4fb72 View commit details
    Browse the repository at this point in the history

  41. Fix update route 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5f55bba View commit details
    Browse the repository at this point in the history

  42. Linit 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    af9e301 View commit details
    Browse the repository at this point in the history

  43. Increase wait for the delete 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8f037c6 View commit details
    Browse the repository at this point in the history

  44. Maximize time to wait for the route deletion

    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    11e6f35 View commit details
    Browse the repository at this point in the history

  45. Fix route update 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    40ffd68 View commit details
    Browse the repository at this point in the history

  46. Fix route update 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    09ba5ad View commit details
    Browse the repository at this point in the history

  47. Test with a 30 second wait 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    89adf47 View commit details
    Browse the repository at this point in the history

  48. Fix flaky test 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2d1a584 View commit details
    Browse the repository at this point in the history

  49. Add disabling IOR and clean up 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil
    yannuil committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    b190c5d View commit details
    Browse the repository at this point in the history

  50. Defer clean up 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil @luksa
    yannuil authored and luksa committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bb4816c View commit details
    Browse the repository at this point in the history

  51. Clear only ior routes 

    Signed-off-by: Yann Liu <yannliu@redhat.com>
    @yannuil @luksa
    yannuil authored and luksa committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    afb11d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. rename newRoute to newRouteController

    @luksa
    luksa committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    c148353 View commit details
    Browse the repository at this point in the history

  2. rename route.go to controller.go

    @luksa
    luksa committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    06c7899 View commit details
    Browse the repository at this point in the history