[maistra-2.4] OSSM-3647: Add feature flag APPLY_WASM_PLUGINS_TO_INBOUND_ONLY
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
jewertow
changed the title
APPLY_WASM_PLUGINS_TO_INBOUND_ONLY
|
/retest |
luksa
approved these changes
Oct 27, 2023
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #876, but adjusted to the newer WasmPlugin API.
In v2.4,
APPLY_WASM_PLUGINS_TO_INBOUND_ONLYwill be ignored when WasmPlugin has specifiedspec.match. Otherwise, users would not be able to migrate to the old API.The only purpose of this flag is enabling safe migration from v2.2 to v2.3 and v2.4. Let's say, I have maistra-2.2 deployed and I use ServiceMeshExtensions with 3scale plugin. This is a step-by-step instruction for safe migration to maistra-2.4:
APPLY_WASM_PLUGINS_TO_INBOUND_ONLYin pilot container, which will ignore the flag at this step.APPLY_WASM_PLUGINS_TO_INBOUND_ONLYis respected by pilot and WASM plugins do not apply to outbound listeners, so there is no outage in apps with 3scale plugin.APPLY_WASM_PLUGINS_TO_INBOUND_ONLYis still respected, sospec.matchcan be added to WasmPlugin objects.spec.match[].mode: SERVER,APPLY_WASM_PLUGINS_TO_INBOUND_ONLYcan be removed from pilot container.