Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] samples: extauthz: do not return request body as a header when it exceeds 60KB #950

Merged

Conversation

mkralik3
Copy link
Contributor

@mkralik3 mkralik3 commented Mar 5, 2024

Backport of istio/istio#49363

…eeds 60KB (#49363)

* samples: do not return request body as a header to avoid 431

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

* Typo fixes

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

---------

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Copy link

openshift-ci bot commented Mar 5, 2024

Hi @mkralik3. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkralik3
Copy link
Contributor Author

mkralik3 commented Mar 5, 2024

/retest

@mkralik3
Copy link
Contributor Author

mkralik3 commented Mar 6, 2024

/retest

@mkralik3
Copy link
Contributor Author

mkralik3 commented Mar 6, 2024

The same test cases are failing, they may need fix. However, they are not related to this PR ( they are also failing in different PRs ) .

@jewertow can it be bypassed and merged?

@jewertow
Copy link
Member

jewertow commented Mar 7, 2024

/retest

2 similar comments
@jewertow
Copy link
Member

jewertow commented Mar 9, 2024

/retest

@jewertow
Copy link
Member

/retest

@jewertow
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 430a0d8 into maistra:maistra-2.5 Mar 12, 2024
10 checks passed
yannuil pushed a commit to yannuil/maistra-istio that referenced this pull request Jun 3, 2024
…eeds 60KB (#49363) (maistra#950)

* samples: do not return request body as a header to avoid 431



* Typo fixes



---------

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
yannuil pushed a commit to yannuil/maistra-istio that referenced this pull request Jun 3, 2024
…eeds 60KB (#49363) (maistra#950)

* samples: do not return request body as a header to avoid 431



* Typo fixes



---------

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
yannuil pushed a commit to yannuil/maistra-istio that referenced this pull request Jun 5, 2024
…eeds 60KB (#49363) (maistra#950)

* samples: do not return request body as a header to avoid 431



* Typo fixes



---------

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants