Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-5556: Set net.ipv4.ip_unprivileged_port_start=0 in ingress and egress gateways #951

Merged
merged 2 commits into from
Mar 13, 2024
Merged

OSSM-5556: Set net.ipv4.ip_unprivileged_port_start=0 in ingress and egress gateways #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47cdce6
OSSM-5556: Use net.ipv4.ip_unprivileged_port_start=0 in gateways chart
jewertow Mar 5, 2024
d532461
Apply change to injected-deployment
jewertow Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions manifests/charts/gateways/istio-egress/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ spec:
runAsGroup: 1337
runAsNonRoot: true
fsGroup: 1337
sysctls:
- name: net.ipv4.ip_unprivileged_port_start
value: "0"
{{- end }}
serviceAccountName: {{ $gateway.name }}-service-account
{{- if .Values.global.priorityClassName }}
Expand Down Expand Up @@ -210,10 +213,6 @@ spec:
- name: TRUST_DOMAIN
value: "{{ .Values.meshConfig.trustDomain }}"
{{- end }}
{{- if not $gateway.runAsRoot }}
- name: ISTIO_META_UNPRIVILEGED_POD
value: "true"
{{- end }}
{{- range $key, $val := $gateway.env }}
- name: {{ $key }}
value: "{{ $val }}"
Expand Down
7 changes: 3 additions & 4 deletions manifests/charts/gateways/istio-egress/templates/injected-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ spec:
runAsGroup: 1337
runAsNonRoot: true
fsGroup: 1337
sysctls:
- name: net.ipv4.ip_unprivileged_port_start
value: "0"
{{- end }}
serviceAccountName: {{ $gateway.name | default "istio-egressgateway" }}-service-account
{{- if .Values.global.priorityClassName }}
Expand Down Expand Up @@ -96,10 +99,6 @@ spec:
{{ toYaml .Values.global.defaultResources | indent 12 }}
{{- end }}
env:
{{- if not $gateway.runAsRoot }}
- name: ISTIO_META_UNPRIVILEGED_POD
value: "true"
{{- end }}
{{- range $key, $val := $gateway.env }}
- name: {{ $key }}
value: {{ $val | quote }}
Expand Down
4 changes: 2 additions & 2 deletions manifests/charts/gateways/istio-egress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ gateways:
name: istio-egressgateway
ports:
- port: 80
targetPort: 8080
targetPort: 80
name: http2
protocol: TCP
- port: 443
name: https
targetPort: 8443
targetPort: 443
protocol: TCP

labels:
Expand Down
7 changes: 3 additions & 4 deletions manifests/charts/gateways/istio-ingress/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ spec:
runAsGroup: 1337
runAsNonRoot: true
fsGroup: 1337
sysctls:
- name: net.ipv4.ip_unprivileged_port_start
value: "0"
{{- end }}
serviceAccountName: {{ $gateway.name }}-service-account
{{- if .Values.global.priorityClassName }}
Expand Down Expand Up @@ -210,10 +213,6 @@ spec:
- name: TRUST_DOMAIN
value: "{{ .Values.meshConfig.trustDomain }}"
{{- end }}
{{- if not $gateway.runAsRoot }}
- name: ISTIO_META_UNPRIVILEGED_POD
value: "true"
{{- end }}
{{- range $key, $val := $gateway.env }}
- name: {{ $key }}
value: "{{ $val }}"
Expand Down
7 changes: 3 additions & 4 deletions manifests/charts/gateways/istio-ingress/templates/injected-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ spec:
runAsGroup: 1337
runAsNonRoot: true
fsGroup: 1337
sysctls:
- name: net.ipv4.ip_unprivileged_port_start
value: "0"
{{- end }}
serviceAccountName: {{ $gateway.name | default "istio-ingressgateway" }}-service-account
{{- if .Values.global.priorityClassName }}
Expand Down Expand Up @@ -96,10 +99,6 @@ spec:
{{ toYaml .Values.global.defaultResources | indent 12 }}
{{- end }}
env:
{{- if not $gateway.runAsRoot }}
- name: ISTIO_META_UNPRIVILEGED_POD
value: "true"
{{- end }}
{{- range $key, $val := $gateway.env }}
- name: {{ $key }}
value: {{ $val | quote }}
Expand Down
4 changes: 2 additions & 2 deletions manifests/charts/gateways/istio-ingress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ gateways:
name: status-port
protocol: TCP
- port: 80
targetPort: 8080
targetPort: 80
name: http2
protocol: TCP
- port: 443
targetPort: 8443
targetPort: 443
name: https
protocol: TCP

Expand Down