Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3343 Create test case for IOR #375

Merged
merged 30 commits into from Jul 11, 2023
Merged

OSSM-3343 Create test case for IOR #375

merged 30 commits into from Jul 11, 2023

Conversation

fjglira
Copy link
Collaborator

@fjglira fjglira commented Mar 2, 2023 •
edited

Creating IOR test cases related to this issue: https://issues.redhat.com/browse/OSSM-1974

This test case is created to check the bug related to this Jira https://issues.redhat.com/browse/OSSM-1693 when all the IOR routes are recreated after ingress-gateway or istiod pod restart

yannuil
yannuil previously requested changes Mar 27, 2023
View reviewed changes
pkg/ossm/ior.go Outdated Show resolved Hide resolved
pkg/ossm/ior.go Outdated Show resolved Hide resolved
scripts/smmr/create_members_ior.sh Outdated Show resolved Hide resolved
templates/smcp-templates/v2.4/cr_2.4_default_template.yaml Show resolved Hide resolved
@fjglira fjglira requested review from yannuil and luksa March 27, 2023 15:55
@fjglira
Copy link
Collaborator Author

fjglira commented Apr 11, 2023

This test case is going to be created directly in 2.4

@yannuil yannuil changed the title Ior testcase OSSM-3343 Create test case for IOR Apr 14, 2023
@fjglira
Copy link
Collaborator Author

fjglira commented Apr 21, 2023

@yannuil Hey, Can I close this PR now?

@yannuil
Rename
fa0a9d4 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@yannuil
Refactor IOR test to v2.4
0eeb7e8 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@openshift-ci openshift-ci bot added size/XXL and removed size/L labels Apr 21, 2023
@yannuil yannuil changed the base branch from maistra-2.3 to maistra-2.4 April 21, 2023 15:08
@openshift-ci openshift-ci bot added size/L and removed size/XXL labels Apr 21, 2023
@yannuil
Copy link
Contributor

yannuil commented Apr 21, 2023

@fjglira Just updated this PR with the refactor changes. We can keep using this PR.

@yannuil yannuil dismissed their stale review April 21, 2023 15:10

Taking over the work. Other should review it.

luksa
luksa previously requested changes May 5, 2023
View reviewed changes
pkg/tests/ossm/ior_test.go Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
@fjglira
Copy link
Collaborator Author

fjglira commented May 9, 2023

@luksa @yannuil I made some changes to fix lint test and to get the test easier to read. I executed in 2.3 and I found that after the Update SMMR to include 3 Namespaces we get the error:
Expect to find 3 Routes but found 1 instead
In theory, this is fixed in 2.3, Do we still have the issue?

@fjglira fjglira changed the base branch from maistra-2.4 to main May 22, 2023 11:33
@fjglira fjglira requested a review from luksa May 22, 2023 11:33
@luksa
Copy link
Contributor

luksa commented May 24, 2023

/retest

@luksa
Copy link
Contributor

luksa commented May 24, 2023

/test all

luksa
luksa reviewed May 24, 2023
View reviewed changes
pkg/tests/ossm/ior_test.go Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
pkg/tests/ossm/ior_test.go Outdated Show resolved Hide resolved
@fjglira @luksa
Update pkg/tests/ossm/ior_test.go
f0f2872 
Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
@rcernich
Copy link

Hey @yannuil, what is the status of this?

@yannuil yannuil requested a review from luksa June 14, 2023 11:54
@yannuil
Map routes to multi line string for comparison
65d5bb1 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@yannuil
Compare route yaml except resourceVersion
d3b7d98 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@yannuil
Improve detection on route changes
8ca5a31 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@yannuil
Lint
5c7af5f 
Signed-off-by: Yann Liu <yannliu@redhat.com>
@fjglira fjglira requested review from luksa and removed request for luksa July 11, 2023 10:40
@openshift-merge-robot openshift-merge-robot merged commit a7f3578 into maistra:main Jul 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannuil yannuil yannuil approved these changes

@jwendell jwendell jwendell approved these changes

@luksa luksa Awaiting requested review from luksa

Assignees
No one assigned
Labels
okay to merge size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fjglira @yannuil @luksa @rcernich @jwendell @openshift-merge-robot @maistra-bot @pbajjuri20