OSSM-3778 Run against each supported SMCP version #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksa
force-pushed
the
OSSM-3778
branch
2 times, most recently
from
ea8c139
to
f663b46
Compare
FilipB
reviewed
Apr 20, 2023
Dockerfile
Outdated
| && curl -Lo ./oc.tar.gz https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz \ | ||
| && tar -xf oc.tar.gz \ | ||
| && rm -f oc.tar.gz \ | ||
| && curl -Lo ./golang.tar.gz https://go.dev/dl/go1.16.15.linux-amd64.tar.gz \ | ||
| && curl -Lo ./golang.tar.gz https://go.dev/dl/go1.19.8.linux-amd64.tar.gz \ |
There was a problem hiding this comment.
Any reason not to use the latest stable version 1.20.3?
| && tar -xf golang.tar.gz -C / \ | ||
| && rm -f golang.tar.gz \ | ||
| && microdnf update \ | ||
| && microdnf clean all | ||
|
|
||
| ENV GOROOT=/go | ||
| ENV TEST_GROUP ${TEST_GROUP} | ||
| ENV GOPATH=/root/go | ||
| ENV GODEBUG "x509ignoreCN=0" |
There was a problem hiding this comment.
This might not be needed anymore, but I'm going to try this in my other PR
There was a problem hiding this comment.
yup, let's remove it in a follow-up PR if you see it's no longer needed.
fjglira
approved these changes
Apr 20, 2023
|
I'll revise the README and ask you for a review of just the readme again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.