New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-3669: initial changes for interop pipeline support #517
Conversation
There will be probably more changes, we just need this one merged to be able to start with the interop openshift CI config draft. |
Dockerfile
Outdated
# using CMD here so it can be easily overwritten when using this in OpenShiftCI | ||
CMD ["/bin/bash", "-c", "scripts/runtests.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this change prevents you from running the image like this:
podman run <image> TestFaultInjection
You're now forced to do it like this:
podman run <image> scripts/runtests.sh TestFaultInjection
This requires knowledge of the image internals (the name and location of the runtests.sh
script).
What exactly do we need to overwrite when using this in OpenShiftCI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking that using TEST_CASE env variable would be good enough, we can describe this in the Readme to use only env variables when working with the container. My understanding is that in openshiftCI config you specify which commands need to be run in the container. Those commands then overwrite the default CMD. I need to check if it's possible to make it work also when using ENTRYPOINT e.g. via --entrypoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if people end up using the image even when running tests manually (so that they don't have to install any prerequisites), it has to be simple to use (e.g. without the TEST_CASE variable)... but it is true, that they may still want to set other variables...
As for OpenShiftCI: that's exactly the reason why I used ENTRYPOINT
instead of CMD
- because you will never want to run anything else than runtests.sh
, but you may want to set additional arguments via CMD
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's use ENTRYPOINT for now. I still need to understand OpenShift CI better. We can change it later if it's going to be really needed.
We need an image which can be run on OCP. This is first change which is required. It contains also some minor improvements.