Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-5382: Fixing the BI test case #648

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Conversation

pbajjuri20
Copy link
Contributor

@pbajjuri20 pbajjuri20 commented Jan 12, 2024

I found this away

Steps:

  1. getting the review pod name and assigned to the variable
  2. adding the variable to the existing the HTML file
  3. creating the new updated file in the same folder
  4. compared with the new file.

@pbajjuri20
Copy link
Contributor Author

Hi @fjglira @monroe-dylan-m :

I'm planning to add the if env.GetArch() == "arm" {} and else. Because we are running the 2.3 and 2.4 test cases as well. It should impact the other SMCP and other platforms.

@fjglira
Copy link
Collaborator

fjglira commented Jan 16, 2024

Hi @fjglira @monroe-dylan-m :

I'm planning to add the if env.GetArch() == "arm" {} and else. Because we are running the 2.3 and 2.4 test cases as well. It should impact the other SMCP and other platforms.

If the solution works for all the arch it's better to have only one way to test everything.

@pbajjuri20
Copy link
Contributor Author

Hi @fjglira @monroe-dylan-m :
I'm planning to add the if env.GetArch() == "arm" {} and else. Because we are running the 2.3 and 2.4 test cases as well. It should impact the other SMCP and other platforms.

If the solution works for all the arch it's better to have only one way to test everything.

Sure, will test against the 2.3 and 2.4 and will update it.

@openshift-ci openshift-ci bot added size/L and removed size/M labels Jan 16, 2024
@pbajjuri20
Copy link
Contributor Author

pbajjuri20 commented Jan 17, 2024

@monroe-dylan-m @fjglira: updated the PR and retest with all test cases. bookinfo 2.3 to 2.4, it is not impacting the other test cases.

Please review it.

pkg/tests/tasks/traffic/common.go Outdated Show resolved Hide resolved
pkg/tests/tasks/traffic/common.go Outdated Show resolved Hide resolved
pbajjuri20

This comment was marked as off-topic.

Copy link
Contributor

@monroe-dylan-m monroe-dylan-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbajjuri20 pbajjuri20 requested review from fjglira and removed request for fjglira January 23, 2024 18:35
@pbajjuri20 pbajjuri20 merged commit a9b054f into maistra:main Jan 23, 2024
9 checks passed
@pbajjuri20 pbajjuri20 deleted the arm_bi branch January 23, 2024 18:40
@pbajjuri20 pbajjuri20 restored the arm_bi branch January 23, 2024 18:42
@pbajjuri20 pbajjuri20 deleted the arm_bi branch January 23, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants