-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-5382: Fixing the BI test case #648
Conversation
Hi @fjglira @monroe-dylan-m : I'm planning to add the if env.GetArch() == "arm" {} and else. Because we are running the 2.3 and 2.4 test cases as well. It should impact the other SMCP and other platforms. |
If the solution works for all the arch it's better to have only one way to test everything. |
Sure, will test against the 2.3 and 2.4 and will update it. |
@monroe-dylan-m @fjglira: updated the PR and retest with all test cases. bookinfo 2.3 to 2.4, it is not impacting the other test cases. Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I found this away
Steps: