MAISTRA-1634: Add gen-check presubmit test for maistra/istio #55
Conversation
Builder image need new tools because of that
| imagePullPolicy: Always | ||
| command: | ||
| - make | ||
| - gen-check |
There was a problem hiding this comment.
This is great. I actually recently added targets to run the code-gen on our additional ServiceMesh bits. I wanted to keep the changes to the upstream Makefile minimal though, so it's not run as part of the normal make gen target. Can we maybe have this bit read:
- make
- maistra-gen-k8s-client
- gen-checkThat should catch our stuff as well.
There was a problem hiding this comment.
Will this target just generate files or it's a check that will fail if the PR author didn't generate them? Note that upstream has gen and gen-check. The latter is meant to fail and to be used in prow.
There was a problem hiding this comment.
This target just generates the files, but the gen-check target works by first running gen then running a script that checks that the git working directory is clean. So this should be enough.
There was a problem hiding this comment.
gotcha, ok, will add that
Builder image need new tools because of that