Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-2006 Alternative multiNamespaceInformer.HasSynced() fix #27

Merged
merged 1 commit into from Oct 7, 2022

Commits on Oct 7, 2022

  1. OSSM-2006 Alternative multiNamespaceInformer.HasSynced() fix (maistra#24

    )
    
    In the previous fix for informer.HasSynced(), the informer factories were constructed with no namespaces, enabling multiNamespaceInformer.HasSynced() to only return true after the member roll controller initialized the factory and informers by calling SetNamespaces(). Unfortunately, this broke all istio tests where the member roll controller isn't involved. In those cases, the factory and informers must be constructed so that they track all namespaces.
    
    Here, we add the ability for the member roll controller to call SetNamespaces(nil) when the factory is added to it as a listener. This ensures that the informer will return false on HasSynced() calls until the controller invokes SetNamespaces() with the actual list of namespaces read from the ServiceMeshMemberRoll.
    
    This ensures that the informer factory works correctly in both scenarios - with and without the member roll controller.
    luksa committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    42ea70a View commit details
    Browse the repository at this point in the history