Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a draft PR to add trackable boolean values to perl: Perl/perl5#19040
This PR adds support for those boolean values to JSON::PP.
The first commit recognizes the core boolean values and encodes them as JSON true/false values. If the core change goes ahead, this would definitely be wanted.
The second commit decodes JSON booleans into core perl boolean values. This would be nice, and is what we would want if perl had always had core boolean values. But it presents compatibility problems. Possibly we'll want a different solution, like a
->core_bools
method as an easy alternative to->boolean_values(!!0, !!1)
.